[Lldb-commits] [lldb] 782ad91 - [lldb] Fix that TestNoSuchArch.py was passing for the wrong reason

Raphael Isemann via lldb-commits lldb-commits at lists.llvm.org
Thu Jan 9 03:10:43 PST 2020


Author: Raphael Isemann
Date: 2020-01-09T12:09:48+01:00
New Revision: 782ad91cc423bf602718e2bf9ffc59e55350463f

URL: https://github.com/llvm/llvm-project/commit/782ad91cc423bf602718e2bf9ffc59e55350463f
DIFF: https://github.com/llvm/llvm-project/commit/782ad91cc423bf602718e2bf9ffc59e55350463f.diff

LOG: [lldb] Fix that TestNoSuchArch.py was passing for the wrong reason

The command here failed due to the type in 'create' but the expect
did not actually check for the error message. This fixes the typo
and adds a check for the actuall error message we should see.

Added: 
    

Modified: 
    lldb/packages/Python/lldbsuite/test/commands/target/create-no-such-arch/TestNoSuchArch.py

Removed: 
    


################################################################################
diff  --git a/lldb/packages/Python/lldbsuite/test/commands/target/create-no-such-arch/TestNoSuchArch.py b/lldb/packages/Python/lldbsuite/test/commands/target/create-no-such-arch/TestNoSuchArch.py
index a780ca275664..4d7f0838f877 100644
--- a/lldb/packages/Python/lldbsuite/test/commands/target/create-no-such-arch/TestNoSuchArch.py
+++ b/lldb/packages/Python/lldbsuite/test/commands/target/create-no-such-arch/TestNoSuchArch.py
@@ -19,8 +19,8 @@ def test(self):
         # Check that passing an invalid arch via the command-line fails but
         # doesn't crash
         self.expect(
-            "target crete --arch nothingtoseehere %s" %
-            (exe), error=True)
+            "target create --arch nothingtoseehere %s" %
+            (exe), error=True, substrs=["error: invalid triple 'nothingtoseehere'"])
 
         # Check that passing an invalid arch via the SB API fails but doesn't
         # crash


        


More information about the lldb-commits mailing list