[Lldb-commits] [PATCH] D72391: [lldb] Add a display name to ClangASTContext instances

[Greg Clayton via Phabricator via lldb-commits]

clayborg added a comment.

I don't mess with the expression parser all that much, but do we still want to see the pointer value in the log output?

current:

  CompleteTagDecl[2] on (ASTContext*)0x7ff31f01d240 Completing (TagDecl*)0x7ff31f01d568 named DeclName1

Should the new one be

  CompleteTagDecl[2] on scratch ASTContext. Completing (TagDecl*)0x7ff31f01d568 named Foo

Or include the pointer value **and** the name:

  CompleteTagDecl[2] on scratch (ASTContext*)0x7ff31f01d240. Completing (TagDecl*)0x7ff31f01d568 named DeclName1

Might be nice to still see the pointer value in case there are multiple ASTContexts with the same name?


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72391/new/

https://reviews.llvm.org/D72391