[Lldb-commits] [PATCH] D72413: Add missing nullptr checks.

Adrian Prantl via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Jan 8 15:56:14 PST 2020


aprantl added a comment.

In D72413#1810969 <https://reviews.llvm.org/D72413#1810969>, @jingham wrote:

> If we can't make a persistent expression state, are we going to be able to do anything useful with expressions?  I don't see anything wrong here, but it seems like we should really be putting up a crunchy frog warning and erroring out of "expr"directly if we really can't make a type system.


I looked at that for a bit, but there is no obvious place where to early exit without refactoring much more of ClangExpressionDeclMap.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72413/new/

https://reviews.llvm.org/D72413





More information about the lldb-commits mailing list