[Lldb-commits] [PATCH] D63540: Fix lookup of symbols with the same address range but different binding

Wed Jan 8 02:56:23 PST 2020

labath added a comment.

I think this is pretty close. The two things I'd change are:

- make the RangeMap constructor take a `const Compare &` instead of a template pack. The std containers do the same, and I don't see a reason to diverge..
- make Compare operate only on the "data" field of the map. The RangeMap methods assume the entries are sorted in a certain way, so changing that in the comparator does not seem useful. The std::sort call can take a lambda or something to first compare the ranges and then the data fields...

It might also be nice to split this off into a separate patch with a unit test and all...

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63540/new/

https://reviews.llvm.org/D63540