[Lldb-commits] [PATCH] D72377: [ldlb/SWIG] Refactor extensions to be non Python-specific.

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere marked 2 inline comments as done.
JDevlieghere added inline comments.


================
Comment at: lldb/scripts/extensions.swig:4
+  const char *lldb::SBTarget::__str__ (){
+    lldb::SBStream stream;
+    $self->GetDescription (stream, lldb::eDescriptionLevelBrief);
----------------
of course this should be factored out and reused across different SB classes. 


================
Comment at: lldb/scripts/lldb.swig:100
 %{
+#include "../include/lldb/Utility/ConstString.h"
 #include "../source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h"
----------------
This is unfortunate but not worse that what's already done for `PythonDataObjects.h`. 


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72377/new/

https://reviews.llvm.org/D72377