[Lldb-commits] [PATCH] D71905: [lldb][tests] Take into account all parent's categories when traverse folders upwards

Tue Jan 7 02:46:02 PST 2020

labath added inline comments.

================
Comment at: packages/Python/lldbsuite/test/test_result.py:119
+        categories = set()
         while folder != '/':
             categories_file_name = os.path.join(folder, ".categories")
----------------
JDevlieghere wrote:
> labath wrote:
> > I don't think this will work on windows. I think we should stop iterating here as soon we reach the top level test folder (I don't know how to check that off-hand, but we should have that piece of information available somewhere.) That will also ensure we don't get confused by some spurious .categories file outside of the test tree.
> We could use the LLDB source root for this, which is already available from dotest through `lldbsuite.lldb_root`.
sounds good.

Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71905/new/

https://reviews.llvm.org/D71905