[Lldb-commits] [PATCH] D72290: [lldb/CMake] Use LLDB's autodetection logic for libxml2

[Konrad Wilhelm Kleine via Phabricator via lldb-commits]

kwk added inline comments.


================
Comment at: lldb/cmake/modules/FindLibXml28.cmake:14
+    if (APPLE)
+      set(LIBXML2_LIBRARIES xml2)
+    endif()
----------------
labath wrote:
> Why is this under `if(APPLE)` ?
To me this looks as if this module file `FileLibXml28.cmake` is only relevant for Apple. In line 10 it falls back to the standard CMake find-module file (`find_package(LibXml2 QUIET)`). Is this correct?


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72290/new/

https://reviews.llvm.org/D72290