[Lldb-commits] [PATCH] D67906: [lldb] Provide tab completion for target select/delete
Konrad Wilhelm Kleine via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Sun Jan 5 23:21:32 PST 2020
kwk added a comment.
Why don't we always print the target index? Wouldn't that be much simpler?
Comment at: lldb/source/Commands/CommandObjectTarget.cpp:76
- strm.Printf("%starget #%u: %s", prefix_cstr ? prefix_cstr : "", target_idx,
+ if (prefix_cstr)
+ strm << prefix_cstr;
Happy New Years! For the rest of file and in particular for the target properties (e.g. `arch`, `platform`), we use a one line `strm.Printf`. But I can understand that you don't want to introduce a `?:` for every argument of the `Printf`. However why don't we always print the target index? Wouldn't that be much simpler?
CHANGES SINCE LAST ACTION
More information about the lldb-commits