[Lldb-commits] [PATCH] D72096: [lldb/Command] Add --force option for `watchpoint delete` command
Med Ismail Bennani via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Fri Jan 3 05:39:01 PST 2020
mib marked an inline comment as done.
mib added inline comments.
Comment at: lldb/packages/Python/lldbsuite/test/commands/watchpoints/watchpoint_commands/TestWatchpointCommands.py:194-196
+ # Delete the watchpoint immediately using the force option.
+ self.expect("watchpoint delete --force",
+ substrs=['All watchpoints removed.'])
> Can't we just add this to the end of another test without spinning up a new process?
> Did you verify that the test failed before your patch? I'm asking because I don't know what m_interpreter.Confirm() does when there's no PTY connected. Does it default to no or yes?
I merge both tests (`auto-confirm` enabled & `--force` flag) into one.
FWIU, m_interpreter.Confirm(message, default_answer) checks first the auto-confirm setting, When enabled, it returns the default answer (true in this case) otherwise, it triggers the IOHandler for the user input.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the lldb-commits