[Lldb-commits] [lldb] 8580397 - [lldb/Python] Remove unused support file (NFC)

Jonas Devlieghere via lldb-commits lldb-commits at lists.llvm.org
Thu Jan 2 16:55:15 PST 2020


Author: Jonas Devlieghere
Date: 2020-01-02T16:55:09-08:00
New Revision: 8580397f2e7d389940fbdd5575f26271df743aee

URL: https://github.com/llvm/llvm-project/commit/8580397f2e7d389940fbdd5575f26271df743aee
DIFF: https://github.com/llvm/llvm-project/commit/8580397f2e7d389940fbdd5575f26271df743aee.diff

LOG: [lldb/Python] Remove unused support file (NFC)

Added: 
    

Modified: 
    

Removed: 
    lldb/packages/Python/lldbsuite/support/optional_with.py


################################################################################
diff  --git a/lldb/packages/Python/lldbsuite/support/optional_with.py b/lldb/packages/Python/lldbsuite/support/optional_with.py
deleted file mode 100644
index f91b3c6fdeb6..000000000000
--- a/lldb/packages/Python/lldbsuite/support/optional_with.py
+++ /dev/null
@@ -1,58 +0,0 @@
-# ====================================================================
-# Provides a with-style resource handler for optionally-None resources
-# ====================================================================
-
-
-class optional_with(object):
-    # pylint: disable=too-few-public-methods
-    # This is a wrapper - it is not meant to provide any extra methods.
-    """Provides a wrapper for objects supporting "with", allowing None.
-
-    This lets a user use the "with object" syntax for resource usage
-    (e.g. locks) even when the wrapped with object is None.
-
-    e.g.
-
-    wrapped_lock = optional_with(thread.Lock())
-    with wrapped_lock:
-        # Do something while the lock is obtained.
-        pass
-
-    might_be_none = None
-    wrapped_none = optional_with(might_be_none)
-    with wrapped_none:
-        # This code here still works.
-        pass
-
-    This prevents having to write code like this when
-    a lock is optional:
-
-    if lock:
-        lock.acquire()
-
-    try:
-        code_fragment_always_run()
-    finally:
-        if lock:
-            lock.release()
-
-    And I'd posit it is safer, as it becomes impossible to
-    forget the try/finally using optional_with(), since
-    the with syntax can be used.
-    """
-
-    def __init__(self, wrapped_object):
-        self.wrapped_object = wrapped_object
-
-    def __enter__(self):
-        if self.wrapped_object is not None:
-            return self.wrapped_object.__enter__()
-        else:
-            return self
-
-    def __exit__(self, the_type, value, traceback):
-        if self.wrapped_object is not None:
-            return self.wrapped_object.__exit__(the_type, value, traceback)
-        else:
-            # Don't suppress any exceptions
-            return False


        


More information about the lldb-commits mailing list