[Lldb-commits] [PATCH] D72096: [lldb/Command] Add --force option for `watchpoint delete` command

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere accepted this revision as: JDevlieghere.
JDevlieghere added a comment.
This revision is now accepted and ready to land.

LGTM with the inline comment(s) addressed.



================
Comment at: lldb/source/Commands/CommandObjectWatchpoint.cpp:463
+
+      return error;
+    }
----------------
Given that error is never actually populated, it might be nice to use `return {}` to make it clear that we're returning a default constructed instance.


================
Comment at: lldb/source/Commands/CommandObjectWatchpoint.cpp:529
 
     return result.Succeeded();
   }
----------------
I know it's not code you touched but moving this into the first if-clause would allow for an early return. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72096/new/

https://reviews.llvm.org/D72096