[Lldb-commits] [lldb] 982a9e3 - [lldb][NFC] Remove unused callback functionality from ClangASTContext

[Raphael Isemann via lldb-commits]

Author: Raphael Isemann
Date: 2019-12-23T13:50:01+01:00
New Revision: 982a9e3d46bbecc9407c9d5df06634f03d21c6cd

URL: https://github.com/llvm/llvm-project/commit/982a9e3d46bbecc9407c9d5df06634f03d21c6cd
DIFF: https://github.com/llvm/llvm-project/commit/982a9e3d46bbecc9407c9d5df06634f03d21c6cd.diff

LOG: [lldb][NFC] Remove unused callback functionality from ClangASTContext

Added: 
    

Modified: 
    lldb/include/lldb/Symbol/ClangASTContext.h
    lldb/source/Symbol/ClangASTContext.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/include/lldb/Symbol/ClangASTContext.h b/lldb/include/lldb/Symbol/ClangASTContext.h
index 0658baa0cecc..cc8be8451571 100644
--- a/lldb/include/lldb/Symbol/ClangASTContext.h
+++ b/lldb/include/lldb/Symbol/ClangASTContext.h
@@ -964,9 +964,6 @@ class ClangASTContext : public TypeSystem {
   std::unique_ptr<PDBASTParser> m_pdb_ast_parser_up;
   std::unique_ptr<ClangASTSource> m_scratch_ast_source_up;
   std::unique_ptr<clang::MangleContext> m_mangle_ctx_up;
-  CompleteTagDeclCallback m_callback_tag_decl = nullptr;
-  CompleteObjCInterfaceDeclCallback m_callback_objc_decl = nullptr;
-  void *m_callback_baton = nullptr;
   uint32_t m_pointer_byte_size = 0;
   bool m_ast_owned = false;
   /// The sema associated that is currently used to build this ASTContext.

diff  --git a/lldb/source/Symbol/ClangASTContext.cpp b/lldb/source/Symbol/ClangASTContext.cpp
index c7ab37998a98..bae93ed7f7cf 100644
--- a/lldb/source/Symbol/ClangASTContext.cpp
+++ b/lldb/source/Symbol/ClangASTContext.cpp
@@ -721,11 +721,6 @@ void ClangASTContext::CreateASTContext() {
   if (target_info)
     m_ast_up->InitBuiltinTypes(*target_info);
 
-  if ((m_callback_tag_decl || m_callback_objc_decl) && m_callback_baton) {
-    m_ast_up->getTranslationUnitDecl()->setHasExternalLexicalStorage();
-    // m_ast_up->getTranslationUnitDecl()->setHasExternalVisibleStorage();
-  }
-
   GetASTMap().Insert(m_ast_up.get(), this);
 
   llvm::IntrusiveRefCntPtr<clang::ExternalASTSource> ast_source_up(