[Lldb-commits] [lldb] 8983d69 - [lldb/Commands] Fix bogus enum entry and add Lua (NFC)
Jonas Devlieghere via lldb-commits
lldb-commits at lists.llvm.org
Sat Dec 21 17:35:57 PST 2019
Author: Jonas Devlieghere
Date: 2019-12-21T17:21:32-08:00
New Revision: 8983d69144d14d6477c377bb91e9c7224e32f753
URL: https://github.com/llvm/llvm-project/commit/8983d69144d14d6477c377bb91e9c7224e32f753
DIFF: https://github.com/llvm/llvm-project/commit/8983d69144d14d6477c377bb91e9c7224e32f753.diff
LOG: [lldb/Commands] Fix bogus enum entry and add Lua (NFC)
Fixes a bogus enum value for the scripting language options, adds an
entry for Lua and refactored the code to use an exhaustive switch.
Added:
Modified:
lldb/source/Commands/CommandObjectBreakpointCommand.cpp
Removed:
################################################################################
diff --git a/lldb/source/Commands/CommandObjectBreakpointCommand.cpp b/lldb/source/Commands/CommandObjectBreakpointCommand.cpp
index 5151181a622f..0cc46a96489f 100644
--- a/lldb/source/Commands/CommandObjectBreakpointCommand.cpp
+++ b/lldb/source/Commands/CommandObjectBreakpointCommand.cpp
@@ -38,7 +38,12 @@ static constexpr OptionEnumValueElement g_script_option_enumeration[] = {
"Commands are in the Python language.",
},
{
- eSortOrderByName,
+ eScriptLanguageLua,
+ "lua",
+ "Commands are in the Lua language.",
+ },
+ {
+ eScriptLanguageDefault,
"default-script",
"Commands are in the default scripting language.",
},
@@ -297,12 +302,14 @@ are no syntax errors may indicate that a function was declared but never called.
option_arg,
g_breakpoint_command_add_options[option_idx].enum_values,
eScriptLanguageNone, error);
-
- if (m_script_language == eScriptLanguagePython ||
- m_script_language == eScriptLanguageDefault) {
+ switch (m_script_language) {
+ case eScriptLanguagePython:
+ case eScriptLanguageLua:
m_use_script_language = true;
- } else {
+ break;
+ case eScriptLanguageNone:
m_use_script_language = false;
+ break;
}
break;
More information about the lldb-commits
mailing list