[Lldb-commits] [PATCH] D71784: Fedora Linux fails `Unwind/thread-step-out-ret-addr-check.test`

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Sat Dec 21 01:37:59 PST 2019


labath added a comment.

As I said on the other patch, this is probably a simpler approach (assuming we can't find a way to make the data section non-executable in a generic way). You'll need to add an `#ifdef` for the section directive though...



================
Comment at: lldb/test/Shell/Unwind/Inputs/thread-step-out-ret-addr-check.s:13
 # memory check.
+nonstandard_stub:
 _nonstandard_stub:
----------------
mossberg wrote:
> Maybe we can just remove the underscore version, and simply use `nonstandard_stub` if it will work everywhere?
Yes, I'm pretty sure that would work.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71784/new/

https://reviews.llvm.org/D71784





More information about the lldb-commits mailing list