[Lldb-commits] [PATCH] D71372: [lldb] Add additional validation on return address in 'thread step-out'

[Jim Ingham via lldb-commits]

Okay, I pushed a change to the test to only run on darwin.  When you have a patch for the other systems, we can take that out again.

Jim


> On Dec 20, 2019, at 2:08 PM, Mark Mossberg via Phabricator <reviews at reviews.llvm.org> wrote:
> 
> mossberg added a comment.
> 
> Took a quick look, and I think the good news is that the failure looks fairly superficial.
> 
>> clang-10: warning: argument unused during compilation: '-fmodules-cache-path=/home/worker/lldb-x86_64-debian/lldb-x86_64-debian/build/lldb-test-build.noindex/module-cache-clang/lldb-shell' [-Wunused-command-line-argument]
>> /home/worker/lldb-x86_64-debian/lldb-x86_64-debian/llvm-project/lldb/test/Shell/Unwind/thread-step-out-ret-addr-check.test:10:10: error: CHECK: expected string not found in input
>> 
>> 1. CHECK: Breakpoint 1: where = {{.*}}`nonstandard_stub
> 
> The failing check was the one merely to see if the breakpoint was set, which I don't believe is related to the actual code changes that were made. Will continue to look. I also will also look at D71784 <https://reviews.llvm.org/D71784>.
> 
> 
> Repository:
>  rG LLVM Github Monorepo
> 
> CHANGES SINCE LAST ACTION
>  https://reviews.llvm.org/D71372/new/
> 
> https://reviews.llvm.org/D71372
> 
> 
>