[Lldb-commits] [PATCH] D71575: [LLDB] Add ObjectFileWasm plugin for WebAssembly debugging

Fri Dec 20 13:04:41 PST 2019

aprantl added inline comments.

================
Comment at: lldb/source/Plugins/ObjectFile/wasm/ObjectFileWasm.cpp:45
+
+/// Reads a LEB128 variable-length unsigned integer, limited to 7 bits.
+llvm::Optional<uint8_t> GetVaruint7(DataExtractor &section_header_data,
----------------
paolosev wrote:
> aprantl wrote:
> > The LLVM coding style requests that doxygen comments should be on the declaration in the header file and not in the implementation.
> This function is not declared in the header. Probably it doesn't need a doxygen comment.
If it isn't declared in a header, then it should be either static or in an anonymous namespace.
Using a doxygen comment is still preferred, since many IDEs will use that to display online help.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71575/new/

https://reviews.llvm.org/D71575