[Lldb-commits] [PATCH] D71487: [LLDB] Fix address computation for inline function

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

In D71487#1792391 <https://reviews.llvm.org/D71487#1792391>, @johannes wrote:

> I'm having some troubles fixing this build failure: 
>  http://lab.llvm.org:8011/builders/lldb-x86_64-debian/builds/1866/
>
> `ninja check-lldb-api` fails but when I try to execute the offending test locally with a command equivalent to the one in the buildbot log, I get below error. I've tried to rebuild lldb*.so etc without success.
>
>   $ llvm-project/lldb/test/API/dotest.py --arch=x86_64 -s b/lldb-test-traces -S nm -u CXXFLAGS -u CFLAGS --executable b/bin/lldb --compiler b/bin/clang --dsymutil b/bin/dsymutil --filecheck b/bin/FileCheck --env ARCHIVER=/usr/bin/ar --env OBJCOPY=/usr/bin/objcopy --env LLVM_LIBS_DIR=b/lib --build-dir b/lldb-test-build.noindex --lldb-module-cache-dir b/lldb-test-build.noindex/module-cache-lldb/lldb-api --clang-module-cache-dir b/lldb-test-build.noindex/module-cache-clang/lldb-api llvm-project/lldb/packages/Python/lldbsuite/test/functionalities/dead-strip -p TestDeadStrip.py
>   LLDB library dir: /home/builduser/build-ld/bin
>   LLDB import library dir: /home/builduser/build-ld/bin
>   lldb version 10.0.0 (git at github.com:llvm/llvm-project revision ea8a86cc8a18fd001e9670705dae3b59f6a4d974)
>     clang revision 92211bf0f15ba46b5eeb88b7ea580ff539dcdd4e
>     llvm revision 92211bf0f15ba46b5eeb88b7ea580ff539dcdd4e
>   Traceback (most recent call last):
>     File "/home/builduser/build-ld/lib/python3.8/site-packages/lldb/__init__.py", line 38, in <module>
>       import _lldb
>   ModuleNotFoundError: No module named '_lldb'
>  
>   During handling of the above exception, another exception occurred:
>  
>   Traceback (most recent call last):
>     File "llvm-project/lldb/test/API/dotest.py", line 7, in <module>
>       lldbsuite.test.run_suite()
>     File "/home/builduser/llvm-project/lldb/packages/Python/lldbsuite/test/dotest.py", line 956, in run_suite
>       import lldb
>     File "/home/builduser/build-ld/lib/python3.8/site-packages/lldb/__init__.py", line 41, in <module>
>       from . import _lldb
>   ImportError: /home/builduser/build-ld/lib/python3.8/site-packages/lldb/_lldb.so: undefined symbol: _ZN5clang17ExternalASTSource2IDE
>
>
>


I've already fixed that (the "problem" was that the test was passing now), but for future reference, the problem here appears to be that you're doing a shared library build (-DBUILD_SHARED_LIBS=ON). In that case you'll need to set LD_LIBRARY_PATH to for python to find dependent libraries correctly.

> There's also another build failure on Windows, I will fix that by adding `REQUIRES: linux` since the tests are using `ld.lld`:
>  http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/11870/

A better fix for that would be to explicitly specify the target to llc (`llc -mtriple x86_64-pc-linux`), as ld.lld works fine on windows too. You should add `REQUIRES: x86` to catch the cases where people don't enable the X86 target, but that's better since everyone can enable the x86 target (and most do), but not everyone runs a linux machine...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71487/new/

https://reviews.llvm.org/D71487