[Lldb-commits] [PATCH] D71575: [LLDB] Add ObjectFileWasm plugin for WebAssembly debugging

[Adrian Prantl via Phabricator via lldb-commits]

aprantl added inline comments.


================
Comment at: lldb/source/Plugins/ObjectFile/wasm/ObjectFileWasm.cpp:45
+
+/// Reads a LEB128 variable-length unsigned integer, limited to 7 bits.
+llvm::Optional<uint8_t> GetVaruint7(DataExtractor &section_header_data,
----------------
The LLVM coding style requests that doxygen comments should be on the declaration in the header file and not in the implementation.


================
Comment at: lldb/source/Plugins/ObjectFile/wasm/ObjectFileWasm.cpp:375
+/// These 64-bit addresses will be used to request code ranges for a specific
+/// module from the WebAssembly engine.
+
----------------
again.. in the header, or inside the function


================
Comment at: lldb/source/Plugins/ObjectFile/wasm/ObjectFileWasm.cpp:452
+
+// Dump a single Wasm section header to the specified output stream.
+void ObjectFileWasm::DumpSectionHeader(llvm::raw_ostream &ostream,
----------------
ditto


================
Comment at: lldb/source/Plugins/ObjectFile/wasm/ObjectFileWasm.h:18
+
+/// \class ObjectFileWasm
+/// Generic Wasm object file reader.
----------------
This line is redundant and can be removed.


================
Comment at: lldb/source/Plugins/ObjectFile/wasm/ObjectFileWasm.h:25
+public:
+  // Static Functions
+  static void Initialize();
----------------
this comment is inconsistent with the others


================
Comment at: lldb/source/Plugins/ObjectFile/wasm/ObjectFileWasm.h:115
+
+  /// Read a range of bytes from the Wasm module
+  DataExtractor ReadImageData(uint64_t offset, size_t size);
----------------
Please make sure to use full sentences that end in a `.` in all comments.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71575/new/

https://reviews.llvm.org/D71575