[Lldb-commits] [PATCH] D71575: [LLDB] Add initial support for WebAssembly debugging

[Raphael Isemann via Phabricator via lldb-commits]

teemperor added inline comments.


================
Comment at: lldb/source/Plugins/DynamicLoader/WASM-DYLD/DynamicLoaderWasmDYLD.cpp:1
+//===-- DynamicLoaderWasmDYLD.cpp --------------------------------*- C++
+//-*-===//
----------------
paolosev wrote:
> aprantl wrote:
> > 1. This hangs over the line
> > 2. a -*- C++ -*- is only necessary for .h files where C vs. C++ is ambiguous
> > 
> Fixed, but I see the -*- C++ -*- in all files.
The line just got cargo-culted into many *.cpp files so all occurrences in source files are unintentional.


================
Comment at: lldb/source/Utility/ArchSpec.cpp:107
+    {eByteOrderLittle, 4, 2, 4, llvm::Triple::arm, ArchSpec::eCore_arm_armv8l,
+     "armv8l"},
     {eByteOrderLittle, 4, 4, 4, llvm::Triple::aarch64_32,
----------------
paolosev wrote:
> sbc100 wrote:
> > Is this just clang format being greedy?
> Yes, it was edited by clang format.
Can you revert that change? clang-format shouldn't touch these unrelated files if you use git-clang-format or something similar.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71575/new/

https://reviews.llvm.org/D71575