[Lldb-commits] [PATCH] D69309: Support template instantiation in the expression evaluator

Tue Dec 17 02:04:31 PST 2019

jarin added a comment.

In D69309#1787481 <https://reviews.llvm.org/D69309#1787481>, @labath wrote:

> In D69309#1787468 <https://reviews.llvm.org/D69309#1787468>, @jarin wrote:
>
> > What Fred proposes makes a lot of sense to me, although the lookup of instantiations might be slow because there would be no accelerator for that (but we could build one).
>
>
> Do we ever lookup instantiations through this API? Seems pretty fragile, due to all the template brackets and all kinds of whitespace one could insert between them...

I did it in this patch and it worked, but I agree it is brittle. Other than that, I think it is not used.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69309/new/

https://reviews.llvm.org/D69309