[Lldb-commits] [PATCH] D71487: [LLDB] Fix address computation for member function linked with lld

[Adrian Prantl via Phabricator via lldb-commits]

aprantl added inline comments.


================
Comment at: lldb/test/Shell/Expr/TestFunctionAddress.lldb:6
+next
+expr argv.four()
+# CHECK: expr argv.four()
----------------
aprantl wrote:
> This would be better suited for a python test. (You can copy the example test as a starting point).
Thinking about it some more, you are testing for a peculiarity in the DWARF emitted by lld. This would actually be best for an assembler or yaml2obj test that guarantees that that peculiarity is actually there. That said, yaml2obj tests make most sense in combination with lldb-test. When you need a live process to run an expression, like here, they make less sense, since they can only run on one particular platform. So I'm not sure what to recommend.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71487/new/

https://reviews.llvm.org/D71487