[Lldb-commits] [PATCH] D71454: [lldb][NFC] Remove all `setUp` overrides that only call the parent implementation

[Raphael Isemann via Phabricator via lldb-commits]

teemperor created this revision.
teemperor added reviewers: labath, JDevlieghere.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

A lot of our tests copied the setUp code from our TestSampleTest.py:

  def setUp(self):
      # Call super's setUp().
      TestBase.setUp(self)

This code does nothing unless we actually do any setUp work in there, so let's remove all these method definitions.


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D71454

Files:
  lldb/packages/Python/lldbsuite/test/api/listeners/TestListener.py
  lldb/packages/Python/lldbsuite/test/commands/apropos/basic/TestApropos.py
  lldb/packages/Python/lldbsuite/test/commands/command/script/import/TestImport.py
  lldb/packages/Python/lldbsuite/test/commands/command/script/import/rdar-12586188/TestRdar12586188.py
  lldb/packages/Python/lldbsuite/test/commands/disassemble/basic/TestFrameDisassemble.py
  lldb/packages/Python/lldbsuite/test/commands/expression/calculator_mode/TestCalculatorMode.py
  lldb/packages/Python/lldbsuite/test/commands/expression/dont_allow_jit/TestAllowJIT.py
  lldb/packages/Python/lldbsuite/test/commands/expression/entry-bp/TestExprEntryBP.py
  lldb/packages/Python/lldbsuite/test/commands/expression/persistent_ptr_update/TestPersistentPtrUpdate.py
  lldb/packages/Python/lldbsuite/test/commands/expression/weak_symbols/TestWeakSymbols.py
  lldb/packages/Python/lldbsuite/test/commands/frame/diagnose/array/TestArray.py
  lldb/packages/Python/lldbsuite/test/commands/frame/language/TestGuessLanguage.py
  lldb/packages/Python/lldbsuite/test/commands/frame/var/TestFrameVar.py
  lldb/packages/Python/lldbsuite/test/commands/register/register/intel_xtended_registers/TestMPXRegisters.py
  lldb/packages/Python/lldbsuite/test/commands/register/register/intel_xtended_registers/mpx_offset_intersection/TestMPXOffsetIntersection.py
  lldb/packages/Python/lldbsuite/test/commands/target/stop-hooks/TestStopHooks.py
  lldb/packages/Python/lldbsuite/test/commands/version/TestVersion.py
  lldb/packages/Python/lldbsuite/test/commands/watchpoints/watchpoint_disable/TestWatchpointDisable.py
  lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/address_breakpoints/TestAddressBreakpoints.py
  lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/address_breakpoints/TestBadAddressBreakpoints.py
  lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/auto_continue/TestBreakpointAutoContinue.py
  lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_language/TestBreakpointLanguage.py
  lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/scripted_bkpt/TestScriptedResolver.py
  lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-caching/TestDataFormatterCaching.py
  lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/type_summary_list_arg/TestTypeSummaryListArg.py
  lldb/packages/Python/lldbsuite/test/functionalities/history/TestHistoryRecall.py
  lldb/packages/Python/lldbsuite/test/functionalities/longjmp/TestLongjmp.py
  lldb/packages/Python/lldbsuite/test/functionalities/pre_run_dylibs/TestPreRunDylibs.py
  lldb/packages/Python/lldbsuite/test/functionalities/stats_api/TestStatisticsAPI.py
  lldb/packages/Python/lldbsuite/test/functionalities/tail_call_frames/sbapi_support/TestTailCallFrameSBAPI.py
  lldb/packages/Python/lldbsuite/test/functionalities/tail_call_frames/thread_step_out_or_return/TestSteppingOutWithArtificialFrames.py
  lldb/packages/Python/lldbsuite/test/functionalities/thread/backtrace_limit/TestBacktraceLimit.py
  lldb/packages/Python/lldbsuite/test/functionalities/tsan/cpp_global_location/TestTsanCPPGlobalLocation.py
  lldb/packages/Python/lldbsuite/test/functionalities/tsan/global_location/TestTsanGlobalLocation.py
  lldb/packages/Python/lldbsuite/test/functionalities/tsan/multiple/TestTsanMultiple.py
  lldb/packages/Python/lldbsuite/test/functionalities/tsan/thread_numbers/TestTsanThreadNumbers.py
  lldb/packages/Python/lldbsuite/test/functionalities/var_path/TestVarPath.py
  lldb/packages/Python/lldbsuite/test/lang/c/find_struct_type/TestFindStructTypes.py
  lldb/packages/Python/lldbsuite/test/lang/c/local_types/TestUseClosestType.py
  lldb/packages/Python/lldbsuite/test/lang/cpp/dynamic-value-same-basename/TestDynamicValueSameBase.py
  lldb/packages/Python/lldbsuite/test/lang/cpp/trivial_abi/TestTrivialABI.py
  lldb/packages/Python/lldbsuite/test/lang/objc/modules-app-update/TestClangModulesAppUpdate.py
  lldb/packages/Python/lldbsuite/test/lang/objc/modules-cache/TestClangModulesCache.py
  lldb/packages/Python/lldbsuite/test/lang/objc/modules-hash-mismatch/TestClangModulesHashMismatch.py
  lldb/packages/Python/lldbsuite/test/lang/objc/modules-inline-functions/TestModulesInlineFunctions.py
  lldb/packages/Python/lldbsuite/test/lang/objc/modules-update/TestClangModulesUpdate.py
  lldb/packages/Python/lldbsuite/test/lang/objcxx/cxx-bridged-po/TestObjCXXBridgedPO.py
  lldb/packages/Python/lldbsuite/test/lang/objcxx/hide-runtime-values/TestObjCXXHideRuntimeValues.py
  lldb/packages/Python/lldbsuite/test/linux/mix-dwo-and-regular-objects/TestMixedDwarfBinary.py
  lldb/packages/Python/lldbsuite/test/macosx/find-app-in-bundle/TestFindAppInBundle.py
  lldb/packages/Python/lldbsuite/test/macosx/thread-names/TestInterruptThreadNames.py
  lldb/packages/Python/lldbsuite/test/macosx/version_zero/TestGetVersionZeroVersion.py
  lldb/packages/Python/lldbsuite/test/python_api/process/io/TestProcessIO.py
  lldb/packages/Python/lldbsuite/test/python_api/sbstructureddata/TestStructuredDataAPI.py
  lldb/packages/Python/lldbsuite/test/python_api/value_var_update/TestValueVarUpdate.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D71454.233747.patch
Type: text/x-patch
Size: 36304 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20191213/113c042e/attachment-0001.bin>