[Lldb-commits] [lldb] 46d970c - TypeCategory: Initialize m_enabled to false

Vedant Kumar via lldb-commits lldb-commits at lists.llvm.org
Thu Dec 12 11:39:50 PST 2019


Author: Vedant Kumar
Date: 2019-12-12T11:39:41-08:00
New Revision: 46d970cc436068af826e5f6a59033dd0f10c570d

URL: https://github.com/llvm/llvm-project/commit/46d970cc436068af826e5f6a59033dd0f10c570d
DIFF: https://github.com/llvm/llvm-project/commit/46d970cc436068af826e5f6a59033dd0f10c570d.diff

LOG: TypeCategory: Initialize m_enabled to false

The initialization was accidentally lost in https://reviews.llvm.org/D71310, causing a ubsan failure:

/Users/buildslave/jenkins/workspace/lldb-cmake-sanitized/llvm-project/lldb/include/lldb/DataFormatters/TypeCategory.h:278:35: runtime error: load of value 190, which is not a valid value for type 'bool'
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /Users/buildslave/jenkins/workspace/lldb-cmake-sanitized/llvm-project/lldb/include/lldb/DataFormatters/TypeCategory.h:278:35 in

http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake-sanitized/621/consoleText

Added: 
    

Modified: 
    lldb/source/DataFormatters/TypeCategory.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/source/DataFormatters/TypeCategory.cpp b/lldb/source/DataFormatters/TypeCategory.cpp
index cc86983fbb99..85699691f52b 100644
--- a/lldb/source/DataFormatters/TypeCategory.cpp
+++ b/lldb/source/DataFormatters/TypeCategory.cpp
@@ -18,7 +18,7 @@ TypeCategoryImpl::TypeCategoryImpl(IFormatChangeListener *clist,
     : m_format_cont("format", "regex-format", clist),
       m_summary_cont("summary", "regex-summary", clist),
       m_filter_cont("filter", "regex-filter", clist),
-      m_synth_cont("synth", "regex-synth", clist),
+      m_synth_cont("synth", "regex-synth", clist), m_enabled(false),
       m_change_listener(clist), m_mutex(), m_name(name), m_languages() {}
 
 static bool IsApplicable(lldb::LanguageType category_lang,


        


More information about the lldb-commits mailing list