[Lldb-commits] [PATCH] D71378: Modifying ImportDeclContext(...) to ensure that we complete each FieldDecl of a RecordDecl when we are importing the definiton

Gabor Marton via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Dec 12 05:03:34 PST 2019

martong added a comment.

Just one more thing, maybe that is too overkill, but I think on a long term we could benefit from a unittest for this case. You could create a test similar to `LLDBLookupTest` in ASTImporterTest.cpp. In that Fixture we use Minimal import and the regular lookup (that is the exact case in LLDB).
In the test itself we could call ImportDefinition on a struct that has fields with record types. And then we could assert that all field's type's have complete types.



More information about the lldb-commits mailing list