[Lldb-commits] [PATCH] D70846: Expression eval lookup speedup by not returning methods in ManualDWARFIndex::GetFunctions

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

I wouldn't want to do (3).

I think the ideal solution would be (2). AppleIndex should also be able to do this kind of filtering, only it'd have to be done differently -- after looking up the name in the accelerator table, it would go to the debug info, and check what exactly does that name refer to. It wouldn't be as efficient as manual index, but it would still be better than doing this filtering somewhere down the pipeline (as it happens now), after we burn more cycles processing entries which are going to be ignored.

However, I think (1) would be also acceptable, particularly if (2) is hard for some reason.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70846/new/

https://reviews.llvm.org/D70846