[Lldb-commits] [PATCH] D71376: [lldb][dotest] Add `#include <algorithm>` to libc++ detection

Jordan Rupprecht via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Dec 11 14:10:23 PST 2019

rupprecht created this revision.
rupprecht added a reviewer: echristo.
Herald added a reviewer: EricWF.
Herald added subscribers: lldb-commits, ldionne.
Herald added a project: LLDB.
echristo accepted this revision.
This revision is now accepted and ready to land.

Speculative fix after 34ef51b5f979 <https://reviews.llvm.org/rG34ef51b5f97933ba12d857d2da8b0d7c133320ce> broke the lldb buildbot on libc++ tests.

  rG LLVM Github Monorepo



Index: lldb/packages/Python/lldbsuite/test/dotest.py
--- lldb/packages/Python/lldbsuite/test/dotest.py
+++ lldb/packages/Python/lldbsuite/test/dotest.py
@@ -856,7 +856,7 @@
         with tempfile.NamedTemporaryFile() as f:
             cmd = [configuration.compiler, "-xc++", "-stdlib=libc++", "-o", f.name, "-"]
             p = subprocess.Popen(cmd, stdin=subprocess.PIPE, stdout=subprocess.PIPE, stderr=subprocess.PIPE, universal_newlines=True)
-            _, stderr = p.communicate("int main() {}")
+            _, stderr = p.communicate("#include <algorithm>\nint main() {}")
             if not p.returncode:
                 return True, "Compiling with -stdlib=libc++ works"
             return False, "Compiling with -stdlib=libc++ fails with the error: %s" % stderr

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D71376.233446.patch
Type: text/x-patch
Size: 845 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20191211/b83fd4f2/attachment.bin>

More information about the lldb-commits mailing list