[Lldb-commits] [PATCH] D71268: [lldb/DWARF] Add support for DW_AT_loclists_base&DW_FORM_loclistx

[Pavel Labath via Phabricator via lldb-commits]

labath marked 2 inline comments as done.
labath added inline comments.


================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:462
+  uint64_t header_size = llvm::DWARFListTableHeader::getHeaderSize(DWARF32);
+  if (loclists_base >= header_size) {
+    m_loclist_table_header.emplace(".debug_loclists", "locations");
----------------
aprantl wrote:
> For symmetry, we could early-exitify this function, too.
will do.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71268/new/

https://reviews.llvm.org/D71268