[Lldb-commits] [PATCH] D71316: [FormatManager] Upstream and test swift bits for GetCandidateLanguages().

Adrian Prantl via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Dec 10 17:14:14 PST 2019


aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

The change looks good with some future refactoring comment inline.



================
Comment at: lldb/source/DataFormatters/FormatManager.cpp:588
+  case lldb::eLanguageTypeObjC:
+    return {lldb::eLanguageTypeObjC, lldb::eLanguageTypeSwift};
   case lldb::eLanguageTypeC:
----------------
Unrelated to this change; it seems this should really be a callback into the Language plugin and not hardcoded in LLDB.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71316/new/

https://reviews.llvm.org/D71316





More information about the lldb-commits mailing list