[Lldb-commits] [PATCH] D71311: LanguageRuntime: Simplify NSException::GetSummary() output

[Davide Italiano via Phabricator via lldb-commits]

davide added inline comments.


================
Comment at: lldb/source/Plugins/Language/ObjC/NSException.cpp:107-109
+  if (NSStringSummaryProvider(*reason_sp, reason_str_summary, options) &&
+      !reason_str_summary.Empty()) {
+    stream.Printf("%s", reason_str_summary.GetData());
----------------
jingham wrote:
> I wonder if it would be better to print "No reason" as the summary when there's not a reason string?  Having the summary generally be there, but then not be there at all when the exception wasn't given a reason string, is a little disconcerting.
Arguably.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71311/new/

https://reviews.llvm.org/D71311