[Lldb-commits] [PATCH] D71297: Remove unsound caching in LanguageCategory

Adrian Prantl via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Dec 10 16:18:14 PST 2019


This revision was automatically updated to reflect the committed changes.
Closed by commit rG2fb07b90dc1c: Remove unsound caching in LanguageCategory (authored by aprantl).
Herald added a project: LLDB.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71297/new/

https://reviews.llvm.org/D71297

Files:
  lldb/source/DataFormatters/LanguageCategory.cpp


Index: lldb/source/DataFormatters/LanguageCategory.cpp
===================================================================
--- lldb/source/DataFormatters/LanguageCategory.cpp
+++ lldb/source/DataFormatters/LanguageCategory.cpp
@@ -110,10 +110,6 @@
       break;
     }
   }
-  if (match_data.GetTypeForCache() &&
-      (!retval_sp || !retval_sp->NonCacheable())) {
-    m_format_cache.Set(match_data.GetTypeForCache(), retval_sp);
-  }
   return (bool)retval_sp;
 }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D71297.233223.patch
Type: text/x-patch
Size: 469 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20191211/a0c4b546/attachment-0001.bin>


More information about the lldb-commits mailing list