[Lldb-commits] [PATCH] D71306: [RFC] Change how we deal with optional dependencies

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Dec 10 15:57:52 PST 2019


JDevlieghere added a comment.

In D71306#1778484 <https://reviews.llvm.org/D71306#1778484>, @mgorny wrote:

> I'm going to be blunt but if you dislike what LLVM does, improve that rather than proliferating inconsistencies between subprojects.


I think LLVM's behavior makes sense for LLVM but makes less sense for LLDB. I'm all for consistency, but that doesn't mean we should shoehorn anything just because that's how it's done in LLVM.

> That said, there are few things that could improve this. We could print a nice summary of which dependencies were found and which were not at the end of CMake run. We could move variables for controlling deps (or maybe even all user-set variables) to a separate file (meson does something like this, i think), so they're easier to find and track.




Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71306/new/

https://reviews.llvm.org/D71306





More information about the lldb-commits mailing list