[Lldb-commits] [PATCH] D71310: RFC: Remove "Validators"

[Adrian Prantl via Phabricator via lldb-commits]

aprantl created this revision.
aprantl added reviewers: jingham, jasonmolenda.
Herald added a subscriber: mgorny.

Data formatter Validators are completely wired up all the way to the SBAPI, but as far as I can tell they are not used anywhere (including swift-lldb) and also are not tested. I'm puzzled by this, so if anyone can share some info about what this was intended for, please let me know.

This patch deletes them as dead code.


https://reviews.llvm.org/D71310

Files:
  lldb/include/lldb/API/SBValue.h
  lldb/include/lldb/Core/ValueObject.h
  lldb/include/lldb/DataFormatters/FormatClasses.h
  lldb/include/lldb/DataFormatters/FormatManager.h
  lldb/include/lldb/DataFormatters/FormattersContainer.h
  lldb/include/lldb/DataFormatters/LanguageCategory.h
  lldb/include/lldb/DataFormatters/TypeCategory.h
  lldb/include/lldb/DataFormatters/TypeValidator.h
  lldb/include/lldb/DataFormatters/ValueObjectPrinter.h
  lldb/include/lldb/Target/Language.h
  lldb/source/API/SBValue.cpp
  lldb/source/Core/ValueObject.cpp
  lldb/source/DataFormatters/CMakeLists.txt
  lldb/source/DataFormatters/DataVisualization.cpp
  lldb/source/DataFormatters/FormatManager.cpp
  lldb/source/DataFormatters/LanguageCategory.cpp
  lldb/source/DataFormatters/TypeCategory.cpp
  lldb/source/DataFormatters/TypeCategoryMap.cpp
  lldb/source/DataFormatters/TypeValidator.cpp
  lldb/source/DataFormatters/ValueObjectPrinter.cpp
  lldb/source/Target/Language.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D71310.233209.patch
Type: text/x-patch
Size: 38902 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20191210/9f60c641/attachment-0001.bin>