[Lldb-commits] [lldb] 90f4355 - Skip TestMultilineCompletion.py on ios testsuite runs.

[Davide Italiano via lldb-commits]

I don't think that it's terribly valuable testing autocompletion on
device, but we should try to avoid calling `run` directly to avoid
these sort of issues.

On Tue, Dec 10, 2019 at 2:55 PM Jason Molenda via lldb-commits
<lldb-commits at lists.llvm.org> wrote:
>
>
> Author: Jason Molenda
> Date: 2019-12-10T14:55:04-08:00
> New Revision: 90f4355b43eaf9eefa02226b98d8cb43f44ca879
>
> URL: https://github.com/llvm/llvm-project/commit/90f4355b43eaf9eefa02226b98d8cb43f44ca879
> DIFF: https://github.com/llvm/llvm-project/commit/90f4355b43eaf9eefa02226b98d8cb43f44ca879.diff
>
> LOG: Skip TestMultilineCompletion.py on ios testsuite runs.
>
> Added:
>
>
> Modified:
>     lldb/packages/Python/lldbsuite/test/commands/expression/multiline-completion/TestMultilineCompletion.py
>
> Removed:
>
>
>
> ################################################################################
> diff  --git a/lldb/packages/Python/lldbsuite/test/commands/expression/multiline-completion/TestMultilineCompletion.py b/lldb/packages/Python/lldbsuite/test/commands/expression/multiline-completion/TestMultilineCompletion.py
> index dc4f36b6f8b6..6fbdaee20510 100644
> --- a/lldb/packages/Python/lldbsuite/test/commands/expression/multiline-completion/TestMultilineCompletion.py
> +++ b/lldb/packages/Python/lldbsuite/test/commands/expression/multiline-completion/TestMultilineCompletion.py
> @@ -14,6 +14,7 @@ class MultilineCompletionTest(PExpectTest):
>      # PExpect uses many timeouts internally and doesn't play well
>      # under ASAN on a loaded machine..
>      @skipIfAsan
> +    @skipIfDarwinEmbedded  # test is written to explicitly "run" the binary
>      def test_basic_completion(self):
>          """Test that we can complete a simple multiline expression"""
>          self.build()
>
>
>
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits