[Lldb-commits] [PATCH] D71297: Remove unsound caching in LanguageCategory

[Adrian Prantl via Phabricator via lldb-commits]

aprantl created this revision.
aprantl added reviewers: jingham, davide.
aprantl added a parent revision: D71296: Replace redundant code in LanguageCategory with templates (NFC).

Analogous to https://reviews.llvm.org/D71233 it is not safe to cache something that depends on the actual ValueObject in a cache then keys only off the type name.


https://reviews.llvm.org/D71297

Files:
  lldb/source/DataFormatters/LanguageCategory.cpp


Index: lldb/source/DataFormatters/LanguageCategory.cpp
===================================================================
--- lldb/source/DataFormatters/LanguageCategory.cpp
+++ lldb/source/DataFormatters/LanguageCategory.cpp
@@ -110,10 +110,6 @@
       break;
     }
   }
-  if (match_data.GetTypeForCache() &&
-      (!retval_sp || !retval_sp->NonCacheable())) {
-    m_format_cache.Set(match_data.GetTypeForCache(), retval_sp);
-  }
   return (bool)retval_sp;
 }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D71297.233181.patch
Type: text/x-patch
Size: 469 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20191210/bd864783/attachment-0001.bin>