[Lldb-commits] [PATCH] D71251: [lldb] Actually enable wchar support in Editline when it is defined in the host config

Tue Dec 10 04:48:45 PST 2019

labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

Looks like there are still some issues with echoing unicode characters on linux, but this is still an improvement over status quo everywhere, so I see no reason to hold it up over that.

================
Comment at: lldb/packages/Python/lldbsuite/test/iohandler/unicode/TestUnicode.py:24-26
+        self.child.send(u'\u1234\n')
+        # We should get out that this is an invalid command with our character as UTF-8.
+        self.child.expect(u"error: '\u1234' is not a valid command.".encode('utf-8'))
----------------
I'd recommend using `self.expect` here. Right now the only difference is that it will do an additional `expect_prompt` after the command (which could possible help with the stability of this test, but probably won't make a difference), but the command may gain additional improvements over time.

Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71251/new/

https://reviews.llvm.org/D71251