[Lldb-commits] [PATCH] D71231: Replace redundant code in FormatManager and FormatCache with templates (NFC)

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Dec 9 23:57:47 PST 2019


labath added a comment.

Not really my area, but it seems reasonable. One thing I'd consider is replacing the functions which return the values through a by-ref argument (e.g. `TypeCategoryMap::Get` with an actual return value. That'd mean one would have to type out the type in the invocation explicitly instead of relying on template argument deduction, but I don't think that's very useful, as one still has to spell out the type in the variable declaration on the preceding line..


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71231/new/

https://reviews.llvm.org/D71231





More information about the lldb-commits mailing list