[Lldb-commits] [PATCH] D71236: [FormatManager] GetCandidateLanguages shouldn't know about ValueObject.
Jim Ingham via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Mon Dec 9 17:26:48 PST 2019
jingham added a comment.
In D71236#1776404 <https://reviews.llvm.org/D71236#1776404>, @aprantl wrote:
> I'm assuming you already checked that this isn't used in swift-lldb either? Otherwise this obviously LGTM.
This is answering the question "which languages have formatters that are compatible with this language." You should not need a live value to determine that, it is a feature of each language. So even if Swift is using the ValueObject version of this, it shouldn't be, and should switch to the LanguageType version.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the lldb-commits