[Lldb-commits] [PATCH] D71233: Do not cache hardcoded formats in FormatManager
Adrian Prantl via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Mon Dec 9 16:48:12 PST 2019
aprantl created this revision.
aprantl added reviewers: jingham, davide.
aprantl added a parent revision: D71231: Replace redundant code in FormatManager and FormatCache with templates (NFC).
The cache in FormatCache uses only a type name as key. The hardcoded formats, synthetic children, etc inspect an entire ValueObject to determine their eligibility, which isn't modelled in the cache. This leads to bugs such as the one in this patch (where two similarly named types in different files have different hardcoded summary providers). The problem is exaggerated in the Swift language plugin due to the language's dynamic nature.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 5902 bytes
Desc: not available
More information about the lldb-commits