[Lldb-commits] [PATCH] D71105: [lldb/Reproducers] Support multiple GDB remotes

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added inline comments.


================
Comment at: lldb/source/Commands/CommandObjectReproducer.cpp:439
 
-      std::vector<GDBRemotePacket> packets;
-      yaml::Input yin((*error_or_file)->getBuffer());
-      yin >> packets;
+      static std::unique_ptr<repro::MultiLoader<repro::GDBRemoteProvider>>
+          multi_loader =
----------------
labath wrote:
> So what about this `static` thing?
This is totally bogus, I don't even remember why or how it ended up there.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71105/new/

https://reviews.llvm.org/D71105