[Lldb-commits] [PATCH] D71183: [lldb] Support for DWARF-5 atomic types

Mon Dec 9 01:17:54 PST 2019

labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

Looks pretty straight-forward. When I wrote this test, I was expecting that an "atomic struct" would be "invalid input". Given that this is actually a thing, it would be nice to add some members to the struct to show that can be displayed too, but I can also do that afterwards...

================
Comment at: lldb/test/Shell/SymbolFile/DWARF/dwarf5-atomic.s:24-25
+        .byte   0                       # EOM(1)
+        .byte   0                       # EOM(2)
+  .byte 2                       # Abbreviation Code
+  .byte 52                      # DW_TAG_variable
----------------
Looks like I didn't remote tabs here. Could you please fix this before submitting?

Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71183/new/

https://reviews.llvm.org/D71183