[Lldb-commits] [PATCH] D71105: [lldb/Reproducers] Support multiple GDB remotes

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere updated this revision to Diff 232653.
JDevlieghere marked an inline comment as done.
JDevlieghere added a comment.

- Address CR feedback.
- Introduce `AbstractRecorder` to reuse code between the `PacketRecorder` and the `DataRecorder`.
- Move GDB related reproducer code into `Utility/GDBRemote.h`.
- Rename `ProcessGDBRemoteProvider` to `GDBRemoteProvider`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71105/new/

https://reviews.llvm.org/D71105

Files:
  lldb/include/lldb/Utility/GDBRemote.h
  lldb/include/lldb/Utility/Reproducer.h
  lldb/source/API/SBDebugger.cpp
  lldb/source/Commands/CommandObjectReproducer.cpp
  lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp
  lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.h
  lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationHistory.cpp
  lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationHistory.h
  lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
  lldb/source/Utility/GDBRemote.cpp
  lldb/source/Utility/Reproducer.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D71105.232653.patch
Type: text/x-patch
Size: 21366 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20191206/9feedd73/attachment-0001.bin>