[Lldb-commits] [PATCH] D69589: [lldb] Refactor all POST_BUILD commands into targets

[Pavel Labath via Phabricator via lldb-commits]

labath added inline comments.


================
Comment at: lldb/CMakeLists.txt:114
+      COMMAND ${CMAKE_COMMAND} -E make_directory ${ARG_DEST_DIR})
+    foreach(src_file ${ARG_FILES})
+      if(ARG_DEST_FILE_NAME)
----------------
tatyana-krasnukha wrote:
> This is quite off-topic, but it would be great if this function could handle whole directories as well as separate files. So adding a script will not require to change this file.
It isn't really off topic, but I don't think it's really feasible, or a good idea even :P.

Think of this as the list of cpp files in the cmake `add_library` calls. Though there are ways to avoid listing the files there (via some sort of globbing, generally), they usually come with their own problems. Either the glob is evaluated at configuration time, and then you have to remember to re-run cmake to pick up the newly added files; or the glob is done at build time, which means that even a noop build needs to reglob everything...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69589/new/

https://reviews.llvm.org/D69589