[Lldb-commits] [PATCH] D70277: [Signal] Allow llvm clients to opt into one-shot SIGPIPE handling

[Vedant Kumar via Phabricator via lldb-commits]

vsk marked an inline comment as done.
vsk added inline comments.


================
Comment at: llvm/lib/Support/Unix/Signals.inc:369
 
-      // Send a special return code that drivers can check for, from sysexits.h.
       if (Sig == SIGPIPE)
+        if (auto OldOneShotPipeFunction =
----------------
aganea wrote:
> @vsk Question question: `SIGPIPE` isn't in the `IntSigs` array anymore (you've removed it at L209), so the above `std::find` will fail when `Sig == SIGPIPE` and this code will never be executed. Most likely this isn't the intended behavior, or I am missing something?
Thanks for catching this, I've fixed this in 9a3f892d018.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70277/new/

https://reviews.llvm.org/D70277