[Lldb-commits] [PATCH] D69589: [lldb] Refactor all POST_BUILD commands into targets

[Stefan Gränitz via Phabricator via lldb-commits]

sgraenitz added a comment.

I'd recommend to be careful when making a change of this size. There are a lot of possible configurations.
If you split it up into a few smaller and more dedicated commits, you will make your life easier. Otherwise someone might just revert everything if this happens to break a bot.

In D69589#1736299 <https://reviews.llvm.org/D69589#1736299>, @aadsm wrote:

> Yeah, weird. I wonder if this is something cmake does implicitly when the target is defined as `FRAMEWORK`: https://cmake.org/cmake/help/latest/prop_tgt/FRAMEWORK.html


This is correct. There is a comment mentioning it here:
https://github.com/llvm/llvm-project/blob/276a5b2d5f1f/lldb/cmake/modules/LLDBFramework.cmake#L44



================
Comment at: lldb/CMakeLists.txt:204
 
-  function(create_relative_symlink target dest_file output_dir output_name)
+  function(add_relative_symlink_target name dest_file output_dir output_name)
     get_filename_component(dest_file ${dest_file} ABSOLUTE)
----------------
This change e.g. is reasonable, but unrelated. It could go into a separate NFC commit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69589/new/

https://reviews.llvm.org/D69589