[Lldb-commits] [PATCH] D70992: Replacing to use of ul suffix in GetMaxU64Bitfield since it not guarenteed to be 64 bit

[Raphael Isemann via Phabricator via lldb-commits]

teemperor accepted this revision.
teemperor added a comment.

LGTM minus a small nitpick. Thanks!



================
Comment at: lldb/source/Utility/DataExtractor.cpp:595
+      (bitfield_bit_size == 64
+           ? -static_cast<uint64_t>(1)
+           : ((static_cast<uint64_t>(1) << bitfield_bit_size) - 1));
----------------
How about `std::numeric_limits<uint64_t>::max()`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70992/new/

https://reviews.llvm.org/D70992