[Lldb-commits] [PATCH] D70907: Change Target::FindBreakpointsByName to return Expected<vector>
Joseph Tremoulet via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Tue Dec 3 09:37:31 PST 2019
JosephTremoulet marked 2 inline comments as done.
JosephTremoulet added inline comments.
================
Comment at: lldb/source/Breakpoint/BreakpointList.cpp:136
+ "FindBreakpointsByName requires a name",
+ llvm::inconvertibleErrorCode());
----------------
JDevlieghere wrote:
> I think `llvm::errc::invalid_argument` would fit.
SGTM; updated.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70907/new/
https://reviews.llvm.org/D70907
More information about the lldb-commits
mailing list