[Lldb-commits] [PATCH] D70932: [EditLine] Fix RecallHistory that makes it move in the opposite direction.

Tue Dec 3 04:50:34 PST 2019

labath added a comment.

In D70932#1766846 <https://reviews.llvm.org/D70932#1766846>, @teemperor wrote:

> Yes, multiline expressions use this code, but I don't see any functional change in this patch that could be tested? It seems to only change the bool to an enum so that we can pass in Swift `Newer`/`Older` instead of cryptic `true`/`false` (and the actual fix is swapping this in swift-lldb).
>
> Anyway, I added a test for going up/down in multiline expressions in rG4821d2a014e02b14223676c98b2ef5244eb91da8 <https://reviews.llvm.org/rG4821d2a014e02b14223676c98b2ef5244eb91da8>. As this seems NFC and the changed  code is now tested, this can land.

Yes, that makes sense. And thank you for adding the test!

Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70932/new/

https://reviews.llvm.org/D70932