[Lldb-commits] [PATCH] D70932: [EditLine] Fix RecallHistory that makes it move in the opposite direction.

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere created this revision.
JDevlieghere added reviewers: jingham, labath, teemperor, clayborg.
Herald added a subscriber: abidh.
Herald added a project: LLDB.

The naming used by editline for the history operations is counter
intuitive to how it's used in lldb for the REPL.

- The H_PREV operation returns the previous element in the history, which is **newer** than the current one.
- The H_NEXT operation returns the next element in the history, which is **older** than the current one.

This exposed itself as a bug in the REPL where the behavior of up- and
down-arrow was inverted. This wasn't immediately obvious because of how we save
the current "live" entry.

This patch fixes the bug and introduces and enum to wrap the editline
operations that  match the semantics of lldb.


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D70932

Files:
  lldb/include/lldb/Host/Editline.h
  lldb/source/Host/common/Editline.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D70932.231794.patch
Type: text/x-patch
Size: 6140 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20191202/60c208da/attachment.bin>