[Lldb-commits] [PATCH] D70851: [lldb] s/FileSpec::Equal/FileSpec::Match

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.

LGTM assuming the answer to my inline comment is negative :-)



================
Comment at: lldb/include/lldb/Utility/FileSpec.h:196
 
   static bool Equal(const FileSpec &a, const FileSpec &b, bool full);
 
----------------
Why do we still need the `Equal` method? Are there cases where `full` is only decided at runtime? Would it be worth to update the call sites to use `==` or `::Match` directly? I think having both `Match` and `Equal` with these semantics is confusing and will likely reintroduce the things you just cleaned up. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70851/new/

https://reviews.llvm.org/D70851