[Lldb-commits] [PATCH] D70906: [lldb] Move register info "augmentation" from gdb-remote into ABI

[Pavel Labath via Phabricator via lldb-commits]

labath created this revision.
labath added reviewers: jasonmolenda, clayborg, tatyana-krasnukha.
Herald added a subscriber: aprantl.
Herald added a project: LLDB.

Previously the ABI plugin exposed some "register infos" and the
gdb-remote code used those to fill in the missing bits. Now, the
"filling in" code is in the ABI plugin itself, and the gdb-remote code
just invokes that.

The motivation for this is two-fold:
a) the "augmentation" logic is useful outside of process gdb-remote. For

  instance, it would allow us to avoid repeating the register number
  definitions in minidump code.

b) It gives more implementation freedom to the ABI classes. Now that

  these "register infos" are essentially implementation details, classes
  can use other methods to obtain dwarf/eh_frame register numbers -- for
  instance they can consult llvm MC layer.

Since the augmentation code was not currently tested anywhere, I took
the opportunity to create a simple test for it.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D70906

Files:
  lldb/include/lldb/Target/ABI.h
  lldb/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestTargetXMLArch.py
  lldb/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/basic_eh_frame.yaml
  lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
  lldb/source/Target/ABI.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D70906.231714.patch
Type: text/x-patch
Size: 21788 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20191202/92547abd/attachment-0001.bin>